[19.01] Delay workflow step execution for discovered & mapped-over input#7633
Merged
dannon merged 2 commits intogalaxyproject:release_19.01from Apr 1, 2019
Merged
[19.01] Delay workflow step execution for discovered & mapped-over input#7633dannon merged 2 commits intogalaxyproject:release_19.01from
dannon merged 2 commits intogalaxyproject:release_19.01from
Conversation
We should only finalize collections up until the map over depth, as indicated by the TODO that is now obsolete. Fixes galaxyproject#5867 and probably a bunch of other issues where workflows don't run to completion.
Member
Author
|
The one failed API test is not relevant, it's because we download something form usegalaxy.org which is down for maintenance atm. |
Member
Author
|
Also fixes #983. |
Contributor
|
@mvdbeek Thanks. This is so great. It solves one of my workflow issues permanently. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should only finalize collections up until the map over depth,
as indicated by the TODO that is now obsolete.
Fixes #5867 and probably
a bunch of other issues where workflows don't run to completion.