[19.01] Backport workflow output rectification#7577
Merged
dannon merged 4 commits intogalaxyproject:release_19.01from Mar 21, 2019
Merged
[19.01] Backport workflow output rectification#7577dannon merged 4 commits intogalaxyproject:release_19.01from
dannon merged 4 commits intogalaxyproject:release_19.01from
Conversation
'tool' steps. Additionally, remove 'output' stars/PJAs from *all* step types when rectifying.
Member
|
@mvdbeek I think it'll actually work without it, but it's more correct to include it. 19.01 does have 'getGalaxyInstance' for accessing the singleton Galaxy. 19.01 doesn't have eslint, though, so it's not going to complain about it in the testing. |
Member
Author
|
Thanks, then I'll include it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@dannon I don't need bfc0e65 for 19.01, right ?
I didn't see any issue in testing, but I'm not sure how to know if
Galaxyis globally available.