Skip to content

[19.01] Use a relative output.publicPath to avoid 404 errors when serving with a url prefix#7481

Merged
dannon merged 2 commits intogalaxyproject:release_19.01from
abretaud:publicpath
Mar 13, 2019
Merged

[19.01] Use a relative output.publicPath to avoid 404 errors when serving with a url prefix#7481
dannon merged 2 commits intogalaxyproject:release_19.01from
abretaud:publicpath

Conversation

@abretaud
Copy link
Contributor

@abretaud abretaud commented Mar 7, 2019

This should fix the first problem from #7474
The changelog is smaller than I thought, but it seems to be enough :)
ping @dannon

@dannon
Copy link
Member

dannon commented Mar 7, 2019

@abretaud Nice! Yeah, I was trying to set it on the fly in the client based on the configuration Galaxy shipped with the whole __webpack_public_path__ var, but it didn't want to cooperate. I didn't even think of just setting it to a relative path at build time -- I'll check and make sure this doesn't have any unintended side effects, but this looks good at first glance!

@abretaud
Copy link
Contributor Author

abretaud commented Mar 7, 2019

Yeah I tried webpack_public_path too until I had this stupid idea hehe

@dannon
Copy link
Member

dannon commented Mar 7, 2019

@abretaud It's not stupid if it works! I'm going to test it out in a sec, but I'm hopeful.

@abretaud
Copy link
Contributor Author

abretaud commented Mar 7, 2019

I've just pushed a fix for the second problem of #7474 : it seems to work on my test setup, but I haven't checked everything (I'm curious to know if it would fix #7162 too)
I'm leaving now (big week-end!), so feel free to edit the PR as you will
Cheers

@dannon
Copy link
Member

dannon commented Mar 7, 2019

Doesn't look like the second fix is addressing the link/routing issues in the client, to me. The first one, though, I think works fine and I haven't found anywhere that it breaks.

@abretaud
Copy link
Contributor Author

abretaud commented Mar 7, 2019

The last commit is because this link element is used by some Galaxy js code to determine the approot, without this the libraries page tries to make xhr calls without the URL prefix and gets 404

@abretaud
Copy link
Contributor Author

Ok, back to business! Anything I can help on this?

@dannon
Copy link
Member

dannon commented Mar 12, 2019

@abretaud Hey, welcome back! The relative path changes work well in my testing. I'm hoping to push another fix to this branch this morning to address more of the second problem here, and then we can get it in and backport as appropriate.

@dannon
Copy link
Member

dannon commented Mar 13, 2019

@abretaud The other prefix issue I was wrangling is different enough that I think I'm going to separate it out and just merge this now. Thank you!

@dannon dannon merged commit 7310026 into galaxyproject:release_19.01 Mar 13, 2019
@nsoranzo nsoranzo changed the title Use a relative output.publicPath to avoid 404 errors when serving with a url prefix [19.01] Use a relative output.publicPath to avoid 404 errors when serving with a url prefix Mar 13, 2019
@nsoranzo nsoranzo removed the triage label Mar 13, 2019
@nsoranzo nsoranzo added this to the 19.05 milestone Mar 13, 2019
Copy link
Member

@jmchilton jmchilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@abretaud
Copy link
Contributor Author

Ok cool, thanks for working on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants