[19.01] Use a relative output.publicPath to avoid 404 errors when serving with a url prefix#7481
Conversation
|
@abretaud Nice! Yeah, I was trying to set it on the fly in the client based on the configuration Galaxy shipped with the whole |
|
Yeah I tried webpack_public_path too until I had this stupid idea hehe |
|
@abretaud It's not stupid if it works! I'm going to test it out in a sec, but I'm hopeful. |
|
Doesn't look like the second fix is addressing the link/routing issues in the client, to me. The first one, though, I think works fine and I haven't found anywhere that it breaks. |
|
The last commit is because this link element is used by some Galaxy js code to determine the approot, without this the libraries page tries to make xhr calls without the URL prefix and gets 404 |
|
Ok, back to business! Anything I can help on this? |
|
@abretaud Hey, welcome back! The relative path changes work well in my testing. I'm hoping to push another fix to this branch this morning to address more of the second problem here, and then we can get it in and backport as appropriate. |
|
@abretaud The other prefix issue I was wrangling is different enough that I think I'm going to separate it out and just merge this now. Thank you! |
|
Ok cool, thanks for working on this! |
This should fix the first problem from #7474
The changelog is smaller than I thought, but it seems to be enough :)
ping @dannon