Fill in needed state defaults when importing manually crafted workflows.#6746
Merged
mvdbeek merged 2 commits intogalaxyproject:devfrom Oct 6, 2018
Merged
Fill in needed state defaults when importing manually crafted workflows.#6746mvdbeek merged 2 commits intogalaxyproject:devfrom
mvdbeek merged 2 commits intogalaxyproject:devfrom
Conversation
0fc9a3b to
8dbd294
Compare
5224b1c to
dedcc21
Compare
dedcc21 to
3e77471
Compare
This was referenced Sep 30, 2018
mvdbeek
approved these changes
Oct 6, 2018
Member
mvdbeek
left a comment
There was a problem hiding this comment.
Awesome, that looks very nice to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes format 2 workflows more palatable since unset default values in conditionals/repeats don't need to be specified when imported this way (xref https://github.com/galaxyproject/planemo/blob/master/tests/data/wf4-distro-tools.gxwf.yml#L18).