[17.05] Backport #4409#4731
Merged
jmchilton merged 3 commits intogalaxyproject:release_17.05from Oct 2, 2017
Merged
Conversation
and make conda_context argument mandatory in functions/methods. This should help making sure the correct context (e.g. channels) is used for all Conda operations. Also remove unused is_target_available() function. Conflicts: lib/galaxy/tools/deps/conda_util.py
The way we were modifying condarc in the ensure_channels_configured() method was broken because we were appending the missing channels at the end, so the final order may not be the one specified in conda_ensure_channels . Also: - not modifying the user condarc is a much better approach - overriding the channel list on the command line will make debugging easier
Member
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #4409 to:
xref. galaxyproject/tools-iuc#1490