python packages: src layout & pure namespace packages#21977
Open
mr-c wants to merge 3 commits intogalaxyproject:devfrom
Open
python packages: src layout & pure namespace packages#21977mr-c wants to merge 3 commits intogalaxyproject:devfrom
src layout & pure namespace packages#21977mr-c wants to merge 3 commits intogalaxyproject:devfrom
Conversation
1f5a4ec to
648455c
Compare
src layout & pure namespace packages
d7ea04e to
c48c854
Compare
a463842 to
a8d3f94
Compare
Contributor
Author
|
It appears that the Selenium/Playwright tests are known-flaky.
remaining issue is the test disabled in 1380873 |
1380873 to
f6642e8
Compare
Contributor
Author
|
local testing/review: # from this PR
cd packages
SOURCE_DATE_EPOCH=1773409251 ./package-build-install.sh -b tool_shed
# SOURCE_DATE_EPOCH minimizes noise from time differences
find . -name "*.whl" -o -name "*.tar.gz" | grep dist | xargs -I{} cp {} ~/src/galaxyPR/new_pkgs/
# repeat for a checkout of the `dev` branch, but into the folder "new_pkgs"
diffoscope ~/src/galaxyPR/{old,new}_pkgs --html-dir ~/src/galaxyPR/pkg_reportAdditions confirmed from all binary wheels and source distributions:
|
f6642e8 to
91600c6
Compare
nsoranzo
reviewed
Mar 13, 2026
nsoranzo
reviewed
Mar 13, 2026
only directories in `lib/galaxy` & `packages/*/galaxy` All other files removed or moved to their own module All references to those files updated, especially galaxy/version.py
As suggested at https://packaging.python.org/en/latest/guides/packaging-namespace-packages/#native-namespace-packages Use setuptools-scm to automatically adds all the SCM-managed files to the sdist instead of manually listing them in packages/*/MANIFEST.in
91600c6 to
024d8ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
only directories in
lib/galaxy&packages/*/src/galaxyAll other files removed or moved to their own module
All references to those files updated, especially
galaxy/version.pySee #21938
How to test the changes?
(Select all options that apply)
License