[24.2] Allow tool state changes in refactor actions#19730
Merged
mvdbeek merged 1 commit intogalaxyproject:release_24.2from Mar 5, 2025
Merged
Conversation
e863a8b to
fdc1599
Compare
This has always been the intention given the correct tool_state_upgrade messages. Fixes https://github.com/galaxyproject/planemo/actions/runs/13438714063/job/37547389150 which happened with a tool update that results in an altered tool state.
fdc1599 to
516f99f
Compare
jmchilton
approved these changes
Mar 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this has always been the intention given the correct tool_state_upgrade messages. Fixes
https://github.com/galaxyproject/planemo/actions/runs/13438714063/job/37547389150 which happened with a tool update that results in an altered tool state.
Note that we're also now more lenient during workflow upload or if a local tool has been altered in a way that invalidates previously saved tool state. Previously a (now) invalid tool state would have resulted in an internal server error and we wouldn't have create a workflow. Now we save the invalid tool state and notify the user when editing or running the workflow:
Editor:
Run form:
How to test the changes?
(Select all options that apply)
License