Simplify required conditional spec. in .ga workflows.#1777
Closed
jmchilton wants to merge 1 commit intogalaxyproject:devfrom
Closed
Simplify required conditional spec. in .ga workflows.#1777jmchilton wants to merge 1 commit intogalaxyproject:devfrom
jmchilton wants to merge 1 commit intogalaxyproject:devfrom
Conversation
Don't force these to have __current_case__ values specified, infer from the conditional input value if specified.
51 tasks
Member
Author
|
Closing in lieu of an alternative implementation by @guerler which goes farther toward removing |
Contributor
|
Thanks for introducing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't force these to have
__current_case__values specified, infer from the conditional input value if these are specified.Probably there are better ways to do this - since the default value should be inferred if it is not there and I'm not sure it works with booleans exactly - but I think this is a step forward.
Ping @guerler - you've been looking at this code a lot lately, what do you think?
The clearest test to verify the workflows are still working is probably: