Fix "database is locked" error (occurring in the context of workflow testing under SQLite)#16208
Merged
mvdbeek merged 1 commit intogalaxyproject:devfrom Jun 8, 2023
Conversation
This solves the workflow transaction error that happened on every workflow scheduling attempt with autocommit=False. This transaction is not needed: every flush that was called in the context of a workflow execution is now wrapped in a transaction that commits.
Member
|
Thank you @jdavcs! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Factored out from #15421.
This solves 🤞 the sqlite database locking error that occurred in the context of testing workflows.
This also solves the workflow transaction error that happened on every workflow scheduling attempt with
autocommit=False. Rationale for theautocommit=Falsefix: this transaction is not needed: every flush that was called in the context of a workflow execution will be wrapped in a transaction that commits.How to test the changes?
(Select all options that apply)
Run this test:
lib/galaxy_test/api/test_jobs.py::TestJobsApi::test_index_workflow_filter_implicit_jobsunder sqlite (i.e., default connection) on the dev branch (will fail with thesqlalchemy.exc.OperationalError: (sqlite3.OperationalError) database is lockederror. Then switch to this branch and rerun. Observe no error.License