[22.05] fix looks_like_yaml_or_cwl_with_class#15439
Merged
mvdbeek merged 5 commits intogalaxyproject:release_22.05from Jan 30, 2023
Merged
[22.05] fix looks_like_yaml_or_cwl_with_class#15439mvdbeek merged 5 commits intogalaxyproject:release_22.05from
mvdbeek merged 5 commits intogalaxyproject:release_22.05from
Conversation
Member
|
Maybe plug in one of the failing documents as a test |
767891f to
e7d7385
Compare
as used in planemo
the string `class: ...` might appear on the first line hence the leading `\n` was wrong I guess its better to use `^` and `$` and add the MULTILINE flag
Contributor
Author
|
OK commited a test first and Now, lets push the fix again. |
mvdbeek
reviewed
Jan 30, 2023
mvdbeek
reviewed
Jan 30, 2023
Co-authored-by: Marius van den Beek <m.vandenbeek@gmail.com>
Contributor
Author
|
Cool. Maybe we can get this and #14572 .. and get another prerelease of 22.06 packages? |
Member
|
Thank you @bernt-matthias! |
|
This PR was merged without a "kind/" label, please correct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the string
class: ...might appear on the first line hence the leading\nwas wrongI guess its better to use
^and$and add the MULTILINE flagBug has been introduced here: #12604
Suggestions for tests welcome
How to test the changes?
(Select all options that apply)
License