Skip to content

[21.09] Fix tool id update when updating tool shed tools in editor#13196

Merged
guerler merged 4 commits intogalaxyproject:release_21.09from
mvdbeek:fix_tool_id_update
Jan 19, 2022
Merged

[21.09] Fix tool id update when updating tool shed tools in editor#13196
guerler merged 4 commits intogalaxyproject:release_21.09from
mvdbeek:fix_tool_id_update

Conversation

@mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Jan 19, 2022

Fixes #13153, likely broken in #11898 (comment)

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

self.assert_workflow_has_changes_and_save()
workflow = self.workflow_populator.download_workflow(workflow_id)
assert workflow['steps']['0']['tool_version'] == '0.1.1'
assert workflow['steps']['0']['tool_id'] == 'toolshed.g2.bx.psu.edu/repos/iuc/compose_text_param/compose_text_param/0.1.1'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is beautiful.

@mvdbeek mvdbeek force-pushed the fix_tool_id_update branch from e2d10ce to 2ed8cf6 Compare January 19, 2022 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants