Allow param_value filter to refer to parameters with multiple values#13039
Conversation
6e9b6d1 to
d30d49a
Compare
d30d49a to
385dbaa
Compare
mvdbeek
left a comment
There was a problem hiding this comment.
Looks great, can you also run the IUC tests against this branch ?
Good idea. I tried galaxyproject/tools-iuc#4318 but it seems that I have insufficient permissions: |
|
Seems that tests of two tools reproducibly (also local) time out. For macs2 it seems that no |
25e9dfb to
147bea5
Compare
|
Seems that the two tools timing out also timeout on dev because of #13136 So at the moment I can not answer if IUC tool tests are affected. |
147bea5 to
2e33be7
Compare
For instance if we want to have a parameter B to select values
that have not been selected in a parameter A .. and A has
`multiple="true"`
```
<param name="A" type="select" multiple="true"/>
<param name="B" type="select">
<options ...>
<filter type="param_value" column="0" ref="A" keep="false"/>
</options>
</param>
```
interferes with another test
seems that it is not possible to refer other input parameters that are defined below in the xml
ie data with multiple=true and collections
|
The IUC tests are finished now: 11 failure 3678 success (compared to 12 in the recent test for the dont_template_version_command branch). the 11 are a subset of the 12. |
|
This PR was merged without a "kind/" label, please correct. |
Consider this:
then this already works if
Ais a simple parameter (text,int, ...) but it failed ifAis a select is a select parameter withmultiple="true".The filter also did not work if
ref_attributeis used for data parameters withmultiple="true"and collection inputs.Also there were no test so far for the
param_valuefilter.galaxy/test/functional/tools/filter_param_value.xml
Line 16 in 23d5c97
I would like to call this a bug and backport it .. ?
How to test the changes?
(Select all options that apply)
License