Skip to content

feature: Single line mode (compact)#94

Merged
gajus merged 3 commits intogajus:masterfrom
Pandorym:master
May 23, 2019
Merged

feature: Single line mode (compact)#94
gajus merged 3 commits intogajus:masterfrom
Pandorym:master

Conversation

@Pandorym
Copy link
Contributor

@Pandorym Pandorym commented May 23, 2019

In some cases, I want to keep the table compact without drawing horizontal lines in the table.

But if I use drawHorizontalLine: () = > false, it makes forms don't draw on the border-top and border-bottom.

Now, with singleLine: true:

╔═════════════╤═════╤══════════╤═══════╤════════╤══════════════╤═══════════════════╗
║ -rw-r--r--  │ 1   │ pandorym │ staff │ 1529   │ May 23 11:25 │ LICENSE           ║
║ -rw-r--r--  │ 1   │ pandorym │ staff │ 16327  │ May 23 11:58 │ README.md         ║
║ drwxr-xr-x  │ 76  │ pandorym │ staff │ 2432   │ May 23 12:02 │ dist              ║
║ drwxr-xr-x  │ 634 │ pandorym │ staff │ 20288  │ May 23 11:54 │ node_modules      ║
║ -rw-r--r--  │ 1,  │ pandorym │ staff │ 525688 │ May 23 11:52 │ package-lock.json ║
║ -rw-r--r--@ │ 1   │ pandorym │ staff │ 2440   │ May 23 11:25 │ package.json      ║
║ drwxr-xr-x  │ 27  │ pandorym │ staff │ 864    │ May 23 11:25 │ src               ║
║ drwxr-xr-x  │ 20  │ pandorym │ staff │ 640    │ May 23 11:25 │ test              ║
╚═════════════╧═════╧══════════╧═══════╧════════╧══════════════╧═══════════════════╝

@Pandorym Pandorym changed the title add Single line mode (compact) feature: Single line mode (compact) May 23, 2019
@coveralls
Copy link

coveralls commented May 23, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 164

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 73.668%
Totals Coverage Status
Change from base Build 161: 0.02%
Covered Lines: 169
Relevant Lines: 230
💛 - Coveralls

gajus
gajus reviewed May 23, 2019
View reviewed changes
.gitignore Outdated
!.gitignore
!.npmignore
!.travis.yml
!.README
Copy link
Owner

@gajus gajus May 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.README should not be ignored.

@gajus gajus merged commit 0627005 into gajus:master May 23, 2019
@gajus
Copy link
Owner

gajus commented May 23, 2019

🎉 This PR is included in version 5.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gajus gajus added the released label May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gajus gajus gajus left review comments

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Pandorym @coveralls @gajus