Skip to content

Use lodash's _.values() to drop the dependency on object.values#78

Merged
gajus merged 1 commit intogajus:masterfrom
realityking:lodash
Sep 4, 2018
Merged

Use lodash's _.values() to drop the dependency on object.values#78
gajus merged 1 commit intogajus:masterfrom
realityking:lodash

Conversation

@realityking
Copy link
Contributor

Always nice to have less dependencies and object.values pulls in a lot of them (it has 4 dependencies).

@coveralls
Copy link

coveralls commented Sep 4, 2018

Pull Request Test Coverage Report for Build 130

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 72.756%

Totals Coverage Status
Change from base Build 128: 0.0%
Covered Lines: 161
Relevant Lines: 223

💛 - Coveralls

@gajus gajus merged commit 83b3b84 into gajus:master Sep 4, 2018
@gajus
Copy link
Owner

gajus commented Sep 4, 2018

🎉 This PR is included in version 5.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@realityking realityking deleted the lodash branch September 4, 2018 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants