Skip to content

Stream borderless fix#101

Merged
gajus merged 3 commits intogajus:masterfrom
raffis:stream-borderless-fix
Aug 15, 2019
Merged

Stream borderless fix#101
gajus merged 3 commits intogajus:masterfrom
raffis:stream-borderless-fix

Conversation

@raffis
Copy link
Copy Markdown
Contributor

@raffis raffis commented Aug 15, 2019

Current situation

If data gets streamed to stdout and no border is configured (void), only the last
line of the data gets written to stdout.

Should

If no border is configured the current line must not be cleared.

Reproduce

const createStream = require('table').createStream;
const getBorderCharacters = require('table').getBorderCharacters;

let config,
  stream;

config = {
  border: getBorderCharacters('void'), //no problem using ramac for example.
  columnDefault: {
    width: 50
  },
  columnCount: 1
};

stream = createStream(config);

setInterval(() => {
  stream.write([new Date()]);
}, 500);

@coveralls
Copy link
Copy Markdown

coveralls commented Aug 15, 2019

Pull Request Test Coverage Report for Build 183

  • 0 of 5 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.1%) to 72.531%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/createStream.js 0 5 0.0%
Totals Coverage Status
Change from base Build 179: -1.1%
Covered Lines: 169
Relevant Lines: 233

💛 - Coveralls

@gajus gajus merged commit db1ad68 into gajus:master Aug 15, 2019
@gajus
Copy link
Copy Markdown
Owner

gajus commented Aug 15, 2019

🎉 This PR is included in version 5.4.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gajus gajus added the released label Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants