Add global favorite model for new chats by gabrielMalonso · Pull Request #23 · gabrielMalonso/t3code

gabrielMalonso · 2026-03-14T11:46:36Z

Summary

Adds a star icon (⭐) next to each model in the provider/model picker
Clicking the star sets that model as the global default for all new chats
The favorite determines both the provider and the model — e.g., favoriting "Claude Opus 4.6" makes new chats open with Claude Code provider + Opus 4.6
Persisted in localStorage via AppSettings, with toast feedback on toggle

Files changed

apps/web/src/appSettings.ts — FavoriteModel schema + getFavoriteModel() / toggleFavoriteModel() helpers
apps/web/src/appSettings.test.ts — 10 new unit tests
apps/web/src/components/chat/ProviderModelPicker.tsx — Star icon UI with stopPropagation handling
apps/web/src/components/ChatView.tsx — Global favorite influences provider + model resolution for new threads

Test plan

Typecheck passes (bun run typecheck)
All 16 tests pass (bun run test)
Lint clean (bun run lint)
Manual: favorite a model → open new chat → correct provider + model shown
Manual: unfavorite → new chat uses system default
Manual: switch favorite across providers → works correctly

🤖 Generated with Claude Code

…dotgg#1001) Co-authored-by: Julius Marminge <julius0216@outlook.com>

…dotgg#955) Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

Co-authored-by: Julius Marminge <julius0216@outlook.com>

…d Linux) (pingdotgg#841) Co-authored-by: Julius Marminge <julius0216@outlook.com>

Co-authored-by: Julius Marminge <julius0216@outlook.com>

…tgg#1006) Co-authored-by: macroscopeapp[bot] <170038800+macroscopeapp[bot]@users.noreply.github.com> Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com> Co-authored-by: codex <codex@users.noreply.github.com> Co-authored-by: cursor[bot] <206951365+cursor[bot]@users.noreply.github.com>

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

…ingdotgg#988) Co-authored-by: Julius Marminge <julius0216@outlook.com>

Co-authored-by: Julius Marminge <julius0216@outlook.com>

- ensure `chat.new` creates a fresh draft after a promoted draft thread - enforce terminal cap per split group (4) while allowing additional terminal groups - refine sidebar row selected/active styling via shared class-name logic and tests

- move chat-wide key handling into `_chat` route-level shortcut handler - extract reusable `useHandleNewThread` hook and `isTerminalFocused` helper - update browser WS fixture to support `terminalOpen` RPC shape

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

… `useLocalStorage` helper (pingdotgg#662) Co-authored-by: Julius Marminge <julius0216@outlook.com>

… remover duplicação

# Conflicts: # apps/web/src/components/ChatView.tsx # apps/web/src/composer-logic.test.ts

- persist a single favorite provider/model in app settings - use favorite model as default for new local draft chats - add star toggle UI in model picker with toast feedback - cover favorite read/toggle behavior with app settings tests

chatgpt-codex-connector · 2026-03-14T11:46:42Z

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

gabrielMalonso · 2026-03-14T11:57:29Z

apps/web/src/appSettings.ts

+): FavoriteModel | null {
+  const fav = settings.favoriteModel;
+  if (!fav || !fav.provider || !fav.model) return null;
+  const provider = fav.provider as ProviderKind;


Bug: Unsafe cast of fav.provider as ProviderKind can crash the app

getFavoriteModel casts fav.provider as ProviderKind (line 177) without validating the string is actually one of "codex" | "claudeCode" | "cursor". Since FavoriteModelSchema only validates provider as Schema.String, any arbitrary string stored in localStorage (via corruption, browser extensions, or manual editing) will pass schema validation.

When an invalid provider string reaches normalizeModelSlug, MODEL_SLUG_ALIASES_BY_PROVIDER[provider] returns undefined, and the subsequent aliases[trimmed] property access throws a TypeError, crashing the entire ChatView component tree during render.

Suggested fix: Either add a guard before the cast:

const VALID_PROVIDERS = new Set(["codex", "claudeCode", "cursor"]); if (!VALID_PROVIDERS.has(fav.provider)) return null;

Or change FavoriteModelSchema to use Schema.Literals(["codex", "claudeCode", "cursor"]) instead of Schema.String for the provider field.

Use Schema.Literals instead of Schema.String for the provider field in FavoriteModelSchema, ensuring invalid provider values from localStorage are rejected at the schema level. Add runtime guard in getFavoriteModel as defense-in-depth. Remove unsafe `as ProviderKind` casts in appSettings.ts and ChatView.tsx. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

juliusmarminge and others added 25 commits March 14, 2026 05:28

remove triggers

e70f44b

feat: replace worktree toggle with discoverable Select dropdown (ping…

9304266

…dotgg#1001) Co-authored-by: Julius Marminge <julius0216@outlook.com>

fix(desktop): show dialog after "Check for Updates" menu action (ping…

5b6b7a8

…dotgg#955) Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

chore: Upgrade marketing app to Astro 6 (pingdotgg#1005)

3158d23

feat(github): add issue templates for automatic triage (pingdotgg#896)

313b4bf

Actions dialog: autofocus script-name field (pingdotgg#912)

cdb74ad

chore: update actions/checkout and actions/github-script (pingdotgg#956)

06c672d

Co-authored-by: Julius Marminge <julius0216@outlook.com>

Add Antigravity to supported editors in Open menu (macOS, Windows, an…

b7f1e02

…d Linux) (pingdotgg#841) Co-authored-by: Julius Marminge <julius0216@outlook.com>

fix: block image uploads during plan mode questions (pingdotgg#621)

bf1b72e

chore: update @vitejs/plugin-react to 6.0.0 (pingdotgg#1002)

3b7ff0d

fix(web): defer diff worker startup until diff opens (pingdotgg#934)

4550a84

Co-authored-by: Julius Marminge <julius0216@outlook.com>

Upgrade oxfmt and oxlint tooling versions (pingdotgg#1010)

5beaca0

chore: regenerate bun.lock after upstream cherry-picks

700f93f

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Add compact Codex tool-call icons and details to the chat timeline (p…

eb87006

…ingdotgg#988) Co-authored-by: Julius Marminge <julius0216@outlook.com>

feat: Allow Overriding Timestamp Format in Settings (pingdotgg#855)

60c9541

fix(web): add default thread env mode setting (pingdotgg#892)

f7e81fa

Co-authored-by: Julius Marminge <julius0216@outlook.com>

Fix new-thread shortcuts when terminal is focused

c118c8f

- move chat-wide key handling into `_chat` route-level shortcut handler - extract reusable `useHandleNewThread` hook and `isTerminalFocused` helper - update browser WS fixture to support `terminalOpen` RPC shape

fix: remove duplicate ChatRouteGlobalShortcuts from cherry-pick merge

78596c5

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

fix: composer @file autocomplete cursor and spacing bugs (pingdotgg#936)

327b70d

fix(web): resolve preferred editor from available editors & introduce…

fcce77f

… `useLocalStorage` helper (pingdotgg#662) Co-authored-by: Julius Marminge <julius0216@outlook.com>

refactor: mover isToolLifecycleItemType para shared/providerRuntime e…

3cc4949

… remover duplicação

Merge remote-tracking branch 'origin/main' into upstream-sync

781e56b

# Conflicts: # apps/web/src/components/ChatView.tsx # apps/web/src/composer-logic.test.ts

github-actions bot added the size:XXL 1,000+ changed lines (additions + deletions). label Mar 14, 2026

gabrielMalonso commented Mar 14, 2026

View reviewed changes

gabrielMalonso and others added 2 commits March 14, 2026 09:30

merge: resolve conflicts with origin/main

9b3442f

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

gabrielMalonso merged commit abc718b into main Mar 14, 2026

github-actions bot added size:L 100-499 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. and removed size:XXL 1,000+ changed lines (additions + deletions). labels Mar 14, 2026

gabrielMalonso deleted the upstream-sync branch March 14, 2026 13:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add global favorite model for new chats#23

Add global favorite model for new chats#23
gabrielMalonso merged 27 commits intomainfrom
upstream-sync

gabrielMalonso commented Mar 14, 2026

Uh oh!

chatgpt-codex-connector bot commented Mar 14, 2026

Uh oh!

gabrielMalonso Mar 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

Conversation

gabrielMalonso commented Mar 14, 2026

Summary

Files changed

Test plan

Uh oh!

chatgpt-codex-connector bot commented Mar 14, 2026

Uh oh!

gabrielMalonso Mar 14, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants