Skip to content

In fmt master, basic_format_string has moved from base.h to xchar.h #3202

@pratikpc

Description

@pratikpc

Took place in this commit

This change causes compile time errors due to:-

  1. Using SPDLOG_FMT_EXTERNAL and using fmt master
  2. spdlog/common needing basic_format_string without SPDLOG_USE_STD_FORMAT
    #ifndef SPDLOG_USE_STD_FORMAT
    template <typename T, typename... Args>
    inline fmt::basic_string_view<T> to_string_view(fmt::basic_format_string<T, Args...> fmt) {
    return fmt;
  3. xchar.h not being included due to absence of the specified definitions
    #if defined(SPDLOG_WCHAR_FILENAMES) || defined(SPDLOG_WCHAR_TO_UTF8_SUPPORT)
    #include <spdlog/fmt/xchar.h>
    #endif

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions