Conversation
8ad049c to
c4814f1
Compare
|
@Asiderr do you want to do anything cleverer than in hughsie/libgusb#49 -- I think adding FreeBSD CI to our deps is probably a long term good plan. |
|
@hughsie currently, I'm testing those changes and I'll leave review/approval. After that, I need to focus on the USB reset problem (it's pretty urgent for us). |
4608f2f to
cd5c8eb
Compare
contrib/freebsd/distinfo
Outdated
| @@ -0,0 +1,3 @@ | |||
| TIMESTAMP = 1622115022 | |||
There was a problem hiding this comment.
I don't see any sed into this file, does it need some?
There was a problem hiding this comment.
There is no need, it's overwritten during the build. make makesum generates distinfo for the current commit:
cd5c8eb#diff-bdce2284300df67bb504fd10f5eb71470dbe6d3c074ff78fc6ccaaf405e6e008R54
There was a problem hiding this comment.
Then perhaps just drop the file alltogether if it's generated during make command.
superm1
left a comment
There was a problem hiding this comment.
I think as part of the addition of this job, the other freebsd built job can be removed. We don't need both.
4ea3dd9 to
dd9d512
Compare
Signed-off-by: Norbert Kamiński <norbert.kaminski@3mdeb.com>
dd9d512 to
ff46b26
Compare
5f24195 to
896cf61
Compare
|
Looks good to me, @superm1 any changes you wanted to see before we merge? |
Just drop |
| pkg install -y meson | ||
| pkg upgrade -y meson | ||
| cd /usr | ||
| git clone https://github.com/3mdeb/freebsd-ports.git --depth 1 -b fwupd ports |
There was a problem hiding this comment.
this bit does worry me slightly; can't we get this from freebsd upstream? Ideally this would all be self contained.
There was a problem hiding this comment.
It will be changed to the upstream repo when fwupd and its dependencies will come into freebsd-ports.
Signed-off-by: Norbert Kamiński <norbert.kaminski@3mdeb.com>
c1cd306 to
dc3b9ba
Compare
|
This is causing a regression for us, Gentoo: https://bugs.gentoo.org/796143 |
Signed-off-by: Norbert Kamiński norbert.kaminski@3mdeb.com
Signed-off-by: Piotr Konkol piotr.konkol@3mdeb.com
Related to: #3031
Type of pull request: