Skip to content

fu-tool.c: Use traditional UNIX record locks if OFD is not available#3159

Merged
hughsie merged 1 commit intofwupd:masterfrom
3mdeb:wip/3mdeb/setlk-fix
Apr 19, 2021
Merged

fu-tool.c: Use traditional UNIX record locks if OFD is not available#3159
hughsie merged 1 commit intofwupd:masterfrom
3mdeb:wip/3mdeb/setlk-fix

Conversation

@Asiderr
Copy link
Collaborator

@Asiderr Asiderr commented Apr 19, 2021

Open file description locks are Linux-specific. If fwupd is not built
for Linux, it should use the traditional UNIX record locks (F_SETLK).

Signed-off-by: Norbert Kamiński norbert.kaminski@3mdeb.com

Type of pull request:

Open file description locks are Linux-specific. If fwupd is not built
for Linux, it should use the traditional UNIX record locks (F_SETLK).

Signed-off-by: Norbert Kamiński <norbert.kaminski@3mdeb.com>
@hughsie
Copy link
Member

hughsie commented Apr 19, 2021

Do we have to manually unlock F_SETLK?

@Asiderr
Copy link
Collaborator Author

Asiderr commented Apr 19, 2021

@hughsie The lock is automatically released when g_close is called.
Ps. CI failed due to some LFVS server problems:
failed to download file: Could not resolve host: cdn.fwupd.org

@hughsie hughsie merged commit 58fbbc2 into fwupd:master Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants