[bugfix] eval list default version + eval-task reason truncation#229
Merged
khushalsonawat merged 2 commits intodevfrom May 5, 2026
Merged
[bugfix] eval list default version + eval-task reason truncation#229khushalsonawat merged 2 commits intodevfrom
khushalsonawat merged 2 commits intodevfrom
Conversation
EvalTemplateListView was hardcoding version_count=1 and current_version="V1" for every template, so changing the default version never showed up in the outer evals list. Adds fetch_version_metadata() helper alongside the other list-page utilities and uses the real default version_number / count.
get_usage was capping the per-log eval_explanation at 200 chars and appending "...", so the frontend could never render the full reason. Send the full explanation; the table can handle visual truncation.
3 tasks
khushalsonawat
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two backend fixes bundled on this branch:
EvalTemplateListViewwas hardcodingversion_count=1/current_version="V1"for every template, so changing the default version never reflected in the outer evals list. Addedfetch_version_metadata()helper inmodel_hub/utils/eval_list.py(bulk count + defaultversion_numberper page, no N+1) and wired it into the view. Falls back toV1/1when a template has no version rows.tracer/eval-task/get_usage/was capping the per-logeval_explanationat 200 chars and appending"..."in the row payload, so the full reason was unrecoverable client-side. Now sends the full explanation; the table can handle visual truncation. The siblingdetail.results_explanationwas already untruncated.Test plan
pytest futureagi/model_hub/tests/test_eval_list.py -k version -v— covers the newtest_list_reflects_default_versioncase (V1, V2 default, V3) and the no-versions fallback/model-hub/eval-templates/list/after promoting a non-V1 version to default → list should now show the new default version/tracer/eval-task/get_usage/for a task with long eval explanations →logs.items[].reasonshould be the full string, no trailing...