Conversation
Contributor
|
I can't do a proper review of the yml today so I took myself off the list of Reviewers since this is acute, but I did see the stuff that Martin showed us, as in:
|
Ahsanadam
approved these changes
Feb 9, 2022
Vimbayinashe
reviewed
Feb 9, 2022
| @@ -16,18 +16,27 @@ jobs: | |||
|
|
|||
| steps: | |||
| - uses: actions/checkout@v2 | |||
Contributor
There was a problem hiding this comment.
It may be that line 18 is a duplication of line 20 and should be deleted.
Contributor
There was a problem hiding this comment.
No it's two different checkouts. First checkout on line 18 does a checkout of main branch. Then the branch badges is checked out to folder badges :)
Vimbayinashe
approved these changes
Feb 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #76
Creates a new .svg file as a image. The images are stored in a dedicated branch called "branch". In that way the images doesn't require two review approvals for each push.