Skip to content

Issue5#60

Merged
LordRekishi merged 33 commits into
mainfrom
issue5
Feb 11, 2022
Merged

Issue5#60
LordRekishi merged 33 commits into
mainfrom
issue5

Conversation

@ReymartNarvaez

Copy link
Copy Markdown
Contributor

#Issue 5. Added config.json located in resources folder and som classes for parsing the json file under the package config in org.fungover.storm.

@Vimbayinashe

Copy link
Copy Markdown
Contributor

@ReymartNarvaez It seems that there are new changes in the main branch that are conflicting with this pull request and a missing semi-colon that is causing a compilation error.

/home/runner/work/storm/storm/src/main/java/org/fungover/storm/server/Server.java:[50,51] ';' expected

Comment thread src/main/java/org/fungover/storm/server/Server.java
Comment thread src/main/resources/config.json Outdated
Comment thread pom.xml
Comment thread src/test/java/org/fungover/storm/config/configStub.json Outdated
Comment thread src/test/java/org/fungover/storm/config/ConfigurationManagerTest.java Outdated
Comment thread src/test/java/org/fungover/storm/config/configStub.json
Comment thread src/main/java/org/fungover/storm/server/Server.java Outdated
Comment thread src/main/java/org/fungover/storm/config/ConfigurationManager.java Outdated
@DarkendHall DarkendHall self-requested a review February 4, 2022 08:58
Comment thread src/main/java/org/fungover/storm/server/Server.java Outdated
Comment thread src/main/resources/config.json Outdated
@LordRekishi

Copy link
Copy Markdown
Contributor

How is this issue coming along? I need this to be finished in order to finish my issue #63

@LordRekishi LordRekishi added the high priority A key feature label Feb 9, 2022
@ReymartNarvaez

Copy link
Copy Markdown
Contributor Author

How is this issue coming along? I need this to be finished in order to finish my issue #63

Working on it, Martin suggested to move the config file from resource folder to make it work with docker

@LordRekishi

Copy link
Copy Markdown
Contributor

How is this issue coming along? I need this to be finished in order to finish my issue #63

Working on it, Martin suggested to move the config file from resource folder to make it work with docker

Maybe put it in etc/storm/config? Martin mention this being a good default folder structure for my files.

@ReymartNarvaez

Copy link
Copy Markdown
Contributor Author

How is this issue coming along? I need this to be finished in order to finish my issue #63

Working on it, Martin suggested to move the config file from resource folder to make it work with docker

Maybe put it in etc/storm/config? Martin mention this being a good default folder structure for my files.

Tried storm/config/config.json but still get problem when I try to run it on docker. Do you think I need to do some changes in Docker file to make it work?

This was linked to issues Feb 11, 2022
Comment thread config/config.json Outdated
Comment thread Dockerfile Outdated
Comment thread etc/storm/config/config.json Outdated
Comment thread pom.xml
@ReymartNarvaez ReymartNarvaez removed a link to an issue Feb 11, 2022
@ReymartNarvaez ReymartNarvaez linked an issue Feb 11, 2022 that may be closed by this pull request

@LordRekishi LordRekishi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@LordRekishi LordRekishi merged commit 20cc99f into main Feb 11, 2022
@LordRekishi LordRekishi deleted the issue5 branch February 11, 2022 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

high priority A key feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Modify Dockerfile in issue 5 Config file

5 participants