Conversation
|
I can have a look at this pull request later on in the day as I first to need to do some reading in order to understand HttpServlet better. |
Co-authored-by: Vimbayinashe Mandaza <55695513+Vimbayinashe@users.noreply.github.com>
Co-authored-by: Vimbayinashe Mandaza <55695513+Vimbayinashe@users.noreply.github.com>
|
Overall this code looks great! I have added a few suggestions in the code. The constructor with parameters for |
|
I have one more suggestion 🙈 . It covers different files so I will copy a diff log here. It would be safer if response.getHeaders() never returns a null value as it is currently able to do in the tests. |
|
As far as I know, this looks like a good solution. I saw that Robin is assigned as a reviewer and left an "approving" comment but did not approve the code. Since I am not educated enough on this subject I will wait for Robin to make an approval. If not, I can look in to it later this afternoon. |
This request should resolve #35
My thought was to make the objects reusable to save heap memory. Therefore, all fields are reset after use.
The the implementation of HttpServlet is to be made in other issues to keep down the code volume for one pull-request.