Skip to content

Logging with log4j#52

Merged
Vimbayinashe merged 1 commit into
mainfrom
issue-40
Feb 2, 2022
Merged

Logging with log4j#52
Vimbayinashe merged 1 commit into
mainfrom
issue-40

Conversation

@ErikssonF

Copy link
Copy Markdown
Contributor

Resolves #40

@LordRekishi

Copy link
Copy Markdown
Contributor

Looks good!

@LordRekishi

Copy link
Copy Markdown
Contributor

We could also incorporate changes I mentioned in Issue #54

SonarLint want us to use formatting instead of concatenation.

It should look like this:
LOGGER.info("Started server on port: {}", server.port);

Instead of like it is now:
LOGGER.info("Started server on port: " + server.port);

@Vimbayinashe Vimbayinashe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Vimbayinashe Vimbayinashe merged commit 751c4f1 into main Feb 2, 2022
@Vimbayinashe Vimbayinashe deleted the issue-40 branch February 2, 2022 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Logging with log4j

3 participants