Skip to content

#95 - I'm a teapot #221

Merged
kappsegla merged 5 commits into
mainfrom
Add-Teapot
Feb 14, 2024
Merged

#95 - I'm a teapot #221
kappsegla merged 5 commits into
mainfrom
Add-Teapot

Conversation

@Danback

@Danback Danback commented Feb 10, 2024

Copy link
Copy Markdown
Contributor

Add /coffee endpoint with 418 I'm a Teapot response

  • Implement Teapot class for handling /coffee requests.
  • Update HttpParser for path extraction.
  • Modify ClientHandler for /coffee response.
  • Add TeapotTest for endpoint testing.

- Implement Teapot class for handling /coffee requests.
- Update HttpParser for path extraction.
- Modify ClientHandler for /coffee response.
- Add TeapotTest for endpoint testing.
- Implement Teapot class for handling /coffee requests.
- Update HttpParser for path extraction.
- Modify ClientHandler for /coffee response.
- Add TeapotTest for endpoint testing.
- Implement Teapot class for handling /coffee requests.
- Update HttpParser for path extraction.
- Modify ClientHandler for /coffee response.
- Add TeapotTest for endpoint testing.
@Danback Danback linked an issue Feb 10, 2024 that may be closed by this pull request
@github-actions

github-actions Bot commented Feb 10, 2024

Copy link
Copy Markdown

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2023.3.1
        with:
          upload-result: true
Contact Qodana team

Contact us at qodana-support@jetbrains.com

Kouroshkt
Kouroshkt previously approved these changes Feb 11, 2024
Comment thread src/test/java/org/fungover/storm/filehandler/re/TeapotTest.java
Comment thread src/test/java/org/fungover/storm/filehandler/re/TeapotTest.java
Comment thread webroot/coffee.html Outdated
- Implement Teapot class for handling /coffee requests.
- Update HttpParser for path extraction.
- Modify ClientHandler for /coffee response.
- Add TeapotTest for endpoint testing.
kappsegla
kappsegla previously approved these changes Feb 12, 2024

@kappsegla kappsegla left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it looks good.

@kappsegla kappsegla requested a review from Kouroshkt February 12, 2024 15:38
# Conflicts:
#	src/main/java/org/fungover/storm/client/ClientHandler.java
@kappsegla kappsegla merged commit 727e51a into main Feb 14, 2024
@kappsegla kappsegla deleted the Add-Teapot branch February 14, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

I'm a teapot

3 participants