Change the setter methods to void type#198
Conversation
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
Mattan41
left a comment
There was a problem hiding this comment.
Could you explain to me why the change of design pattern?
|
They had return value and Setter methods have no return they make an opration. |
Mattan41
left a comment
There was a problem hiding this comment.
void version is best practice for Setters.
I changed the Setter's methods to void type in Configuration.java.