[BugFix] Fix test_l2 crash on HistogramDataPoint without .value

Samuel Shen · Samuel Shen · commit 7c3c32b0f972 · 2026-04-10T05:28:42.000-04:00
_read_counters() iterates all metrics from the InMemoryMetricReader,
not just counters. When another library registers a histogram on the
same MeterProvider, the reader returns HistogramDataPoint objects
which lack .value (they have .sum/.count instead). Guard with hasattr.

Signed-off-by: Samuel Shen &lt;slshen@uchciago.edu&gt;
diff --git a/tests/v1/mp_observability/subscribers/metrics/test_l2.py b/tests/v1/mp_observability/subscribers/metrics/test_l2.py
@@ -53,7 +53,11 @@ def _read_counters() -> dict[str, int]:
         for scope_metrics in resource_metrics.scope_metrics:
             for metric in scope_metrics.metrics:
                 for dp in metric.data.data_points:
-                    result[metric.name] = int(dp.value)
+                    # Only counter/sum data points have .value;
+                    # skip histograms and other types that may be
+                    # registered on the same MeterProvider.
+                    if hasattr(dp, "value"):
+                        result[metric.name] = int(dp.value)
     return result
 
 
