Skip to content

Fix the links to the relevant Scala files#905

Merged
fthomas merged 2 commits intofthomas:masterfrom
kyusu:patch-1
Feb 8, 2021
Merged

Fix the links to the relevant Scala files#905
fthomas merged 2 commits intofthomas:masterfrom
kyusu:patch-1

Conversation

@kyusu
Copy link
Contributor

@kyusu kyusu commented Feb 2, 2021

While browsing the README.md I noticed that the links to the Scala files in the "Provided Predicates" section are broken.

The links in the provided predicates section were partly broken
@codecov
Copy link

codecov bot commented Feb 2, 2021

Codecov Report

Merging #905 (cdd1add) into master (51b3ce9) will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #905      +/-   ##
==========================================
+ Coverage   91.52%   91.63%   +0.11%     
==========================================
  Files          48       49       +1     
  Lines         531      538       +7     
  Branches        8        8              
==========================================
+ Hits          486      493       +7     
  Misses         45       45              
Impacted Files Coverage Δ
...la/eu/timepit/refined/cats/unorderedFoldable.scala 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51b3ce9...cdd1add. Read the comment docs.

@fthomas
Copy link
Owner

fthomas commented Feb 5, 2021

Thanks for the PR, @kyusu. I broke the links while adding support for Scala 3 where I moved the source files to Scala version specific directories, e.g: https://github.com/fthomas/refined/blob/master/modules/core/shared/src/main/scala-3.0+/eu/timepit/refined/boolean.scala
I'd prefer linking to these files instead of the files in the predicate package since the latter contain only forwarders to the real code in the former files.

@kyusu
Copy link
Contributor Author

kyusu commented Feb 8, 2021

@fthomas
Thanks for looking at the pull request. I'll change the links!

Copy link
Owner

@fthomas fthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kyusu!

@kyusu
Copy link
Contributor Author

kyusu commented Feb 8, 2021

I've changed the links to boolean, numeric & generic.

@fthomas fthomas merged commit 6cf601e into fthomas:master Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants