Remove shapeless dependency in scala 3#1193
Merged
fthomas merged 1 commit intofthomas:masterfrom Jun 15, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1193 +/- ##
=======================================
Coverage 92.69% 92.69%
=======================================
Files 65 65
Lines 835 835
Branches 26 30 +4
=======================================
Hits 774 774
Misses 61 61 |
fthomas
approved these changes
Jun 15, 2023
Owner
fthomas
left a comment
There was a problem hiding this comment.
Looks great, thanks @mrdziuban!
Contributor
Author
|
Thanks @fthomas! Do you have any idea when you might plan to release a new version with the changes? |
Owner
|
0.11.0 with these changes has been released. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1173
This removes the shapeless dependency completely from the scala 3 version of each project. Where there was a natural replacement, I swapped it in:
shapeless.HNilis nowscala.EmptyTupleshapeless.HListis nowscala.Tupleshapeless.::is nowscala.*:N <: shapeless.Natis nowN <: Intshapeless.nat._Nis now justN, taking advantage of literal typesshapeless.Succis nowscala.compiletime.ops.int.Sshapeless.Witness.Auxis nowscala.ValueOfThere was no logical replacement for
shapeless.tag.@@, so I removed code referencing it