Add pureconfig for scala3 [fixes fthomas/refined#1092]#1162
Merged
fthomas merged 8 commits intofthomas:masterfrom Mar 13, 2023
ivan-klass:pureconfig-scala3
Merged
Add pureconfig for scala3 [fixes fthomas/refined#1092]#1162fthomas merged 8 commits intofthomas:masterfrom ivan-klass:pureconfig-scala3
fthomas merged 8 commits intofthomas:masterfrom
ivan-klass:pureconfig-scala3
Conversation
Owner
|
Thanks for the PR, @ivan-klass! The Scala 3 build failed with: |
fthomas
reviewed
Mar 11, 2023
Codecov Report
@@ Coverage Diff @@
## master #1162 +/- ##
==========================================
+ Coverage 92.66% 92.69% +0.02%
==========================================
Files 63 65 +2
Lines 832 835 +3
Branches 26 29 +3
==========================================
+ Hits 771 774 +3
Misses 61 61
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Contributor
Author
|
Linking #1092 to this (I wonder why PR title doesn't work as described by docs |
Owner
The CI checks this with MiMa. I just checked this locally again to make sure that it is compatible: Seems to be fine. |
fthomas
reviewed
Mar 12, 2023
...g/shared/src/main/scala-3.0-/eu/timepit/refined/pureconfig/TypeDescribeVersionSpecific.scala
Show resolved
Hide resolved
fthomas
reviewed
Mar 12, 2023
...g/shared/src/main/scala-3.0+/eu/timepit/refined/pureconfig/TypeDescribeVersionSpecific.scala
Show resolved
Hide resolved
fthomas
approved these changes
Mar 12, 2023
Owner
fthomas
left a comment
There was a problem hiding this comment.
Looks great. Thanks again, @ivan-klass!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
ConfigReaderandConfigWriterfor refined typesI've kept 2.13 signature as is in order to keep binary compatibility - I'll be happy if one can help checking if it is actually maintained.
Also, now refined
ConfigReaderandConfigWritercan be obtained independently fromConfigConvert(more basic instances have lower priority when resolving).I tend to think that
ConfigWriteris used much more rarely in practice thenConfigReader. But with previous code it was impossible to getConfigReader[T Refined P]if you only haveConfigReader[T]but noConfigWriter[T]