Fix/remove shapeless from scalacheck string module#1157
Merged
fthomas merged 3 commits intofthomas:masterfrom Mar 3, 2023
Merged
Conversation
Contributor
Author
|
wow, looks like I broke everything ! |
Owner
|
Yeah, we need to duplicate the sources for Scala 2 and Scala 3 to preserve binary compatibility. My last commit did that. |
Codecov Report
@@ Coverage Diff @@
## master #1157 +/- ##
=======================================
Coverage 92.66% 92.66%
=======================================
Files 63 63
Lines 832 832
Branches 26 26
=======================================
Hits 771 771
Misses 61 61
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes shapeless from
eu.timepit.refined.scalacheckstring arbitraries. (as discussed in #1156 ) in order to bring scala3 compatibility.NB :
NativePlatformfrom scalacheck build matrix in order to get it to work :(