Closed
Conversation
rabernat
reviewed
Oct 18, 2022
Co-authored-by: Ryan Abernathey <ryan.abernathey@gmail.com>
Member
|
Thanks for kicking this off. We will also need to do more work in the future, as v3 eventually gains more features that don't get backported to v2. For example, I don't know if we can already use the v3 unfinished sharding code to do what preffs does, concatenating multiple target byteranges to a single chunk for some of the data chunks. I suppose when v3 is finished and released, we could decide to drop v2 completely here, but I suspect it will be around for quite some time yet. |
Closed
Contributor
Author
|
Somehow I messed up my fork here. I'm going to close this PR and I'll reopen. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR experiments with adding Zarr v3 support to Kerchunk.
In most cases, this simply requires passing the
zarr_versionparameter to thezarr.groupconstructor. The primary exception is incombine.pywhere lots of v2 metadata keys are hard coded. I have not tried to tackle that part of the codebase yet.If you are reviewing this, I suggest starting with the hdf5 translator and the Python 3.10 GitHub action.
towards #235