Skip to content

Update entrypoint selection#680

Merged
martindurant merged 1 commit intofsspec:masterfrom
jrbourbeau:entrypoints-select
Jun 21, 2021
Merged

Update entrypoint selection#680
martindurant merged 1 commit intofsspec:masterfrom
jrbourbeau:entrypoints-select

Conversation

@jrbourbeau
Copy link
Copy Markdown
Contributor

@jrbourbeau jrbourbeau commented Jun 21, 2021

Newer versions of Python and the importlib_metadata backport have deprecated get(...) in favor of .select(...). This helps avoid the following warning (xref this CI build)

 fsspec/__init__.py:49
  /home/runner/work/filesystem_spec/filesystem_spec/fsspec/__init__.py:49: DeprecationWarning: SelectableGroups dict interface is deprecated. Use select.
    for spec in entry_points.get("fsspec.specs", []):

@martindurant
Copy link
Copy Markdown
Member

martindurant commented Jun 21, 2021

Bahh, this thing has changed too m many times! thanks for digging it out.

@martindurant martindurant merged commit a84d7fe into fsspec:master Jun 21, 2021
@jrbourbeau jrbourbeau deleted the entrypoints-select branch June 21, 2021 15:56
@jrbourbeau jrbourbeau mentioned this pull request Jun 24, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jrbourbeau @martindurant