mv: no-op when paths are the same #1218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Any chance of adding a test in one of the backends? |
Contributor
Author
|
Where should we add this test (which test file)? |
Member
|
I suggest fsspec.implementations.tests.test_memory and use a test fixture |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: fsspec/s3fs#711
Previous: If you run
mv('path', 'path'), themvfunction will callcpand thenrm, resulting in the removal of the original 'path'.Revised: If you run
mv('path', 'path'), themvfunction will not perform any action as the source and destination paths are the same.