Use F#10 for the main lib #614
Draft
+55
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
475a5ed to
49c70bb
Compare
10.0.x 9.0.x
This reverts commit 714fe0b.
e213a85 to
ce22ec7
Compare
e213a85 to
654851c
Compare
654851c to
809178a
Compare
| <DefineConstants Condition=" '$(Configuration)' == 'Test'">$(DefineConstants);TEST_TRACE</DefineConstants> | ||
| <DefineConstants Condition=" '$(Configuration)' == 'Fable'">$(DefineConstants);FABLE_COMPILER</DefineConstants> | ||
| <DefineConstants Condition=" '$(Configuration)' == 'Fable4'">$(DefineConstants);FABLE_COMPILER;FABLE_COMPILER_4</DefineConstants> | ||
| <TargetFramework>net8.0</TargetFramework> |
Member
There was a problem hiding this comment.
Do you want to use target framework net10?
Contributor
|
@wallymathieu , @gusty : As part of fixing compiler regressions spotted in this PR, I was automatically running all targets and when successfully running them, I realized it also made an unintended push to gh-pages. Would you mind having a look and reverting if needed? |
Member
Author
No worries, I just reverted. Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the introduction of F#9 there seems to be a breaking change in backwards compatibility.
Although we can't fix the compiler, we can produce a lib that will work when consumed from F#9, still targeting .net8