Add support for the PAGE_METC_TYPE page type#75
Conversation
|
Close/reopen to trigger wormow |
|
Thanks for this contribution! It would be great if you could add a test to cover this page type. Do you know of an online example file with this file page type that you would be able to add to the unit tests? The tests are done in https://github.com/fsprojects/FSharp.Data.Toolbox/blob/master/tests/FSharp.Data.Toolbox.Sas.Tests/Integration.fs, and the csv file in that folder has the urls of files that get downloaded and tested. It’s possible that some of the files that are being skipped in the ‘failingfiles’ set in integration.fs have this meta type. If so, then you could use one of those as the test files rather than locating a new one. |
|
Unfortunately, the files that I mentioned above are confidential. So I can't share them. As for the files that are being skipped in the integration.fs file - most of them are no longer available for download. I tried to find files to replicate this issue on the Internet, but with no luck. |
|
Ok, thanks for checking the failing files. Given the small change and the great documentation of the issue that you provided let’s go ahead and merge this in. It will show up in the nuget.org feed shortly. Let me know if you find any issues with it. Thanks again! |
According to the description of the SAS7BDAT format and the comments in this file pages with the PAGE_METC_TYPE type can be processed in the same way as the PAGE_META_TYPE pages.
We stumbled upon several files with PAGE_METC_TYPE pages. And after this fix, we were able to import them successfully.