inotify: don't remove sibling watches sharing a path prefix#754
Merged
Conversation
removePath used strings.HasPrefix, so removing a recursive watch on /tmp/a also dropped a sibling watch on /tmp/ab. Match on a path boundary instead.
Contributor
Author
|
Plan to cut v1.10.1 once this lands. |
Contributor
Author
|
Spotted the same prefix bug in two more places: recursive rename in |
Contributor
Author
|
Thank you |
Merged
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
watches.removePathusedstrings.HasPrefix(p, path)to find descendants of a recursive watch, so removing/tmp/a/...also dropped a sibling watch on/tmp/ab. Match on a path-separator boundary so only the target and its real descendants are removed.