Conversation
…eaned up after Remove This moves a number of tests from backend_inotify_test.go to fsnotify_test.go, as they're not really inotify-specific. In particular, it moves the "stress test", which creates a bunch of events/files. It also expands this test to (potentially) create many more than just 1,000 files, depending on how many the system will allow. Unfortunately these tests seem pretty flaky on kqueue platforms, where they're allowed to fail for now (failing the test won't fail the test run). This seems to expose some existing limits/problems that need to fixed in a future PR. Also test that the internal state is cleaned up with TestRemoveState(). The Windows backend doesn't have a test for it (or rather, it doesn't run) as it *doesn't* clean the state properly, but I found it too confusing to fix 🤷 Need to spend some time on that in the future. Reorder/rename some GitHub Actions test runs to show nicer in the UI. Fixes #42 Fixes #268
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves a number of tests from backend_inotify_test.go to
fsnotify_test.go, as they're not really inotify-specific. In particular,
it moves the "stress test", which creates a bunch of events/files. It
also expands this test to (potentially) create many more than just 1,000
files, depending on how many the system will allow.
Unfortunately these tests seem pretty flaky on kqueue platforms, where
they're allowed to fail for now (failing the test won't fail the test
run). This seems to expose some existing limits/problems that need to
fixed in a future PR.
Also test that the internal state is cleaned up with TestRemoveState().
The Windows backend doesn't have a test for it (or rather, it doesn't
run) as it doesn't clean the state properly, but I found it too
confusing to fix 🤷 Need to spend some time on that in the future.
Reorder/rename some GitHub Actions test runs to show nicer in the UI.
Fixes #42
Fixes #268