Integration Tests: change 1ms sleeps to 50ms#422
Merged
nshalman merged 3 commits intofsnotify:mainfrom Jan 20, 2022
Merged
Conversation
When testing the FEN code repeatedly and under system load I can sometimes get these tests to fail with a missed WRITE event. With these longer sleeps I have been unable to produce any test failures.
nathany
previously approved these changes
Jan 20, 2022
nathany
approved these changes
Jan 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
When testing the FEN code repeatedly and under
system load I can sometimes get these tests to fail
with a missed WRITE event. With these longer sleeps
I have been unable to produce any test failures.
This is unashamedly in support of #12 / #371
Additionally, this PR gives slightly more friendly names to the sleep durations based on their purposes.
Where should the reviewer start?
Is there any good reason not to do this? It seems reasonable to me and
it prevents spurious test failures.
How should this be manually tested?
N/A