Conversation
nshalman
approved these changes
Aug 24, 2021
Contributor
nshalman
left a comment
There was a problem hiding this comment.
This revert is fine. We should probably also update go.mod to retract v1.5.0
See https://golangtutorial.dev/tips/retract-go-module-versions/
This was referenced Aug 24, 2021
eliobischof
added a commit
to caos/orbos
that referenced
this pull request
Aug 30, 2021
fsnotify had a bad release fsnotify/fsnotify#394 (review)
eliobischof
added a commit
to caos/orbos
that referenced
this pull request
Aug 30, 2021
fsnotify had a bad release fsnotify/fsnotify#394 (review)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Revert #289 to resolve regressions in #390 #393 #389.
We can give it another go. @Code0x58.
Where should the reviewer start?
How should this be manually tested?
go test