Conversation
|
You won't get that merge approved, as it only works with one OS. Check this thread: #191 |
|
@radu-munteanu, you mean it does not work in one OS? I totally understand that fsnotify tends to be as cross-platform as possible. But not implementing something rather essential I cannot. Besides windows has file locking so combination of file locking and |
|
@betim - I'd recommend switching to this fork as it'll better suit your needs by supporting IN_CLOSE_WRITE https://github.com/ericbrisrubio/fsnotify |
|
@bevand10, Dave, if there is no IN_CLOSE_WRITE or similar operation how would one implement processing of newly created or changed files? I personally, being a nub tho, don't know how that could be implemented. Without CLOSE operation the fsnotify seems to have next to now real-world application at all. |
|
@bevand10 - I'm using my own fork for this, it works very well. |
|
Thanks for the PR. We would like to spin out a inotify package with support for all OS features on Linux, but fsnotify itself needs a common API across every OS. |
What does this pull request do?
Adds OPEN and CLOSE events from unix.*
Where should the reviewer start?
inotify.go and fsnotify.go
How should this be manually tested?
Add a folder with watcher.Add(...) then try to open/modify/write file.