Skip to content

rm go1.5.4 from travis config since the linter doesn't build in 1.5#175

Merged
nathany merged 1 commit intofsnotify:masterfrom
pattyshack:travis
Oct 5, 2016
Merged

rm go1.5.4 from travis config since the linter doesn't build in 1.5#175
nathany merged 1 commit intofsnotify:masterfrom
pattyshack:travis

Conversation

@pattyshack
Copy link
Copy Markdown

No description provided.

@nathany
Copy link
Copy Markdown
Contributor

nathany commented Oct 5, 2016

Thanks.

Out of curiosity, what error occurred when the linter didn't build? I'm a bit surprised over the issue.

@nathany
Copy link
Copy Markdown
Contributor

nathany commented Oct 5, 2016

Oh, I see.

# github.com/golang/lint
../../golang/lint/lint.go:249: undefined: types.ImportMode

from https://travis-ci.org/fsnotify/fsnotify/jobs/165118920

There is a closed issue with a similar error golang/lint#246

And lint doesn't test itself on Go 1.5.4

golang/lint@e39d629#diff-354f30a63fb0907d4ad57269548329e3

@nathany nathany merged commit b4f2a68 into fsnotify:master Oct 5, 2016
@pattyshack pattyshack deleted the travis branch October 5, 2016 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants