Skip to content

fix not working in windows because path (#30)#34

Merged
frou merged 3 commits into
frou:masterfrom
kltk:patch-1
Apr 9, 2019
Merged

fix not working in windows because path (#30)#34
frou merged 3 commits into
frou:masterfrom
kltk:patch-1

Conversation

@kltk

@kltk kltk commented Feb 15, 2019

Copy link
Copy Markdown
Contributor

#30

@frou

frou commented Mar 30, 2019

Copy link
Copy Markdown
Owner

It's valid to use basename here, but on the other hand, isn't this tackling the symptom rather than the problem? Why is Windows (or Git-for-Windows?) having a problem with an absolute path argument in the first place?

@frou frou merged commit bf4fda4 into frou:master Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants