Conversation
|
FYI, I have layer shell (floating window) support in my Wayland + EGUI wrapper (wayapp): https://github.com/Ciantic/wayapp/blob/main/examples/egui_layer_shell_example.rs It of course works only on Wayland, as that is the point of my wrapper, no winit or other crossplatform setups. |
Collaborator
|
Hey! Thank you for that information! |
Owner
Author
|
@Ciantic that sounds very promising and might resolve our last issue with egui. I'll try the wrapper in the next couple of days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Over the past year centerpiece startup time has gotten slower and slower. This is mostly due to iced receiving more features and not being optimized for fast startup performance. The most pressing issue which influences the startup time of centerpiece negatively is font loading. This is tracked over #183, has been an issue for a long time and does not seem to be fixed anytime soon.
Since centerpiece is using a very minimal feature set of iced, I've been thinking about switching to another, more lightweight, ui library for quite some time. This PR contains the change from iced to egui.
My recent tests have shown the following startup times of centerpiece
This biggest issue right now is that eui has no support for the wayland layer shell protocol. egui is waiting for layer shell support in winit (rust-windowing/winit#2582, rust-windowing/winit#4044).
We'll be merging this PR anyways, even if it does not provide native floating support in wayland, it does provide a significant performance improvement. Floating can be fixed by configuring floating for centerpiece windows in your window manager. We'll keep this change on main for quite a while and if we decide to release it without floating support, it will become a breaking change.
This resolves #246.
This resolves #174.