Fix glob expansion for local dependencies#20
Merged
llucax merged 2 commits intofrequenz-floss:v1.x.xfrom Mar 26, 2026
Merged
Conversation
Using `xargs` to safely parse the `DEPENDENCIES` environment variable prevented the shell from expanding globs (e.g., `dist/*.whl`). This broke workflows that relied on wildcard patterns for passing locally built wheel files to `pip`. This commit delegates the installation step to a companion script `scripts/install-dependencies.sh`. This script safely splits the arguments, explicitly handles glob expansions for paths (restoring the `*.whl` support), and proactively blocks unsafe dependencies (like editable installs or requirement files) to ensure arbitrary code execution from the checked-out PR context remains prevented. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
tiyash-basu-frequenz
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
xargsto safely parse theDEPENDENCIESenvironment variable prevented the shell from expanding globs (e.g.,dist/*.whl). This broke workflows that relied on wildcard patterns for passing locally built wheel files topip.This commit delegates the installation step to a companion script
scripts/install-dependencies.sh. This script safely splits the arguments, explicitly handles glob expansions for paths (restoring the*.whlsupport), and proactively blocks unsafe dependencies (like editable installs or requirement files) to ensure arbitrary code execution from the checked-out PR context remains prevented.