Bump, widen and fix setuptools dependency#392
Merged
llucax merged 2 commits intofrequenz-floss:v0.x.xfrom Apr 23, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates dependency versions and boundaries for setuptools and its related packages, ensuring consistency across different dependency groups, and prepares release notes for v0.13.3.
- Bumped setuptools and setuptools_scm versions in the build-system.
- Widened setuptools version boundaries in the API and development dependencies.
- Adjusted cookiecutter template configuration for pytest and mkdocs.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pyproject.toml | Updated dependency versions and version ranges for setuptools. |
| cookiecutter/{{cookiecutter.github_repo_name}}/pyproject.toml | Reordered conditional blocks in pytest configuration. |
| cookiecutter/{{cookiecutter.github_repo_name}}/mkdocs.yml | Modified mkdocstrings configuration, including renaming the key. |
Comments suppressed due to low confidence (1)
cookiecutter/{{cookiecutter.github_repo_name}}/mkdocs.yml:119
- The configuration key for external references was changed from 'import:' to 'inventories:'. Please verify if this change is intentional and update the associated comment to reflect the new key if needed.
inventories:
Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
There was a problem hiding this comment.
Pull Request Overview
This PR updates the dependency requirements for setuptools and setuptools_scm in the build and project settings and simplifies the release notes for the v0.13.3 release.
- Updated build-system dependencies to "setuptools == 79.0.0" and "setuptools_scm[toml] == 8.3.0".
- Widened the version ranges for setuptools and types-setuptools to allow up to version 80.
- Simplified RELEASE_NOTES.md to reflect the dependency update.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pyproject.toml | Updated dependency versions and widened version ranges for consistency across sections. |
| RELEASE_NOTES.md | Condensed release notes to document the dependency update for the v0.13.3 release. |
Comments suppressed due to low confidence (1)
pyproject.toml:60
- Ensure the updated upper bound for setuptools (< 80) is consistently applied across all dependency sections and that related comments are updated to reflect this change.
"setuptools >= 67.6.0, < 80",
Contributor
Author
|
Will force-merge as it is pretty trivial and most people is away this week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also prepare release notes for the v0.13.3 release.