Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: frequenz-floss/frequenz-repo-config-python
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.7.3
Choose a base ref
...
head repository: frequenz-floss/frequenz-repo-config-python
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.7.4
Choose a head ref
  • 8 commits
  • 4 files changed
  • 2 contributors

Commits on Nov 3, 2023

  1. Clear release notes 

    Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
    @llucax
    llucax committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    a9f7788 View commit details
    Browse the repository at this point in the history

  2. mike: Sort pre-releases as older than stable releases 

    For the same major and minor, pre-releases were sorted as newer than
stable releases, but this is not correct.

Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
    @llucax
    llucax committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    94dd0ed View commit details
    Browse the repository at this point in the history

  3. mike: Remove unused function 

    Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
    @llucax
    llucax committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    02de9fe View commit details
    Browse the repository at this point in the history

  4. Don't parse mike versions while sorting 

    There are 2 main reasons for this:

1. Parsing the mike versions is less future proof, as if more fields
   are added to the JSON in the future, we'll remove them from the
   output, making the sorting more bug prone and more costly to
   maintain.

2. Avoiding the extra wrapping in `sort_mike_versions()` makes it easier
   to test, as otherwise we need to do the extra wrapping in tests,
   wrapping that is really not related to sorting so it adds noise to
   the tests.

Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
    @llucax
    llucax committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    60e05f6 View commit details
    Browse the repository at this point in the history

  5. Use a more explicit name for the _TestCase class 

    We are going to add more wrapped test cases, so it is better to use a
more explicit name.

Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
    @llucax
    llucax committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    6d8b449 View commit details
    Browse the repository at this point in the history

  6. Add tests for compare_mike_version() and sort_mike_versions() 

    Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
    @llucax
    llucax committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    be6df37 View commit details
    Browse the repository at this point in the history

  7. Update release notes 

    Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
    @llucax
    llucax committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    0ee52d5 View commit details
    Browse the repository at this point in the history

  8. Fix mike version sorting (#171) 

    For the same major and minor, pre-releases were sorted as newer than
stable releases, but this is not correct. This PR fixes that.

It also makes the sorting of the `versions.json` file more robust, as it
doesn't parse and re-serialize the version object, but instead only uses
the `version` field for sorting, and the rest of the fields are dumping
verbatim without any rewriting.

This means that if new versions of `mike` add more fields to the JSON,
we won't need to update the sorting code, as it will just work.
    @llucax
    llucax authored Nov 3, 2023
    Configuration menu
    Copy the full SHA
    8bf6c38 View commit details
    Browse the repository at this point in the history
Loading