Don't allow a default port in URLs by default#85
Merged
llucax merged 1 commit intofrequenz-floss:v0.x.xfrom Sep 23, 2024
Merged
Don't allow a default port in URLs by default#85llucax merged 1 commit intofrequenz-floss:v0.x.xfrom
llucax merged 1 commit intofrequenz-floss:v0.x.xfrom
Conversation
b345971 to
aa13732
Compare
Allow client implementors to set a default port for gRPC URLs via the `defaults` argument but make the `parse_grpc_uri` function and `BaseApiClient` class don't provide a default port unless explicitly set by the implementors, as using a default port really depends on the specific API being implemented. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
aa13732 to
81405db
Compare
Contributor
Author
|
Squashed and enabled auto-merge. |
Contributor
Author
daniel-zullo-frequenz
approved these changes
Sep 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We allow client implementors to set a default port for gRPC URLs again, but the
parse_grpc_urifunction andBaseApiClientclass still don't provide a default port unless explicitly set.