Remove the CanStreamData RPC#87
Merged
tiyash-basu-frequenz merged 1 commit intofrequenz-floss:v0.x.xfrom Aug 9, 2023
Merged
Conversation
Contributor
Author
|
Marking it as blocked for now until we finalise the release plan for v0.15.2. |
Contributor
|
Unblocking as v0.15.2 was released 🎉 |
llucax
previously approved these changes
Aug 9, 2023
It can be checked by calling the `StreamComponentData` method, and checking if the response is an error or not. Signed-off-by: Tiyash Basu <tiyash.basu@frequenz.com>
2ead24e to
4210b9f
Compare
Contributor
Author
|
Rebased on v0.x.x to resolve conflicts. |
matthias-wende-frequenz
approved these changes
Aug 9, 2023
llucax
approved these changes
Aug 9, 2023
thomas-nicolai-frequenz
left a comment
There was a problem hiding this comment.
Looks good from my side.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It can be checked by calling the
StreamComponentDatamethod, and checking if the response is an error or not.