Update frequenz-api-common to v0.8.3#396
Update frequenz-api-common to v0.8.3#396tiyash-basu-frequenz merged 2 commits intofrequenz-floss:v0.x.xfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the release notes messaging around which API versions are considered unchanged/stable for the release, in the context of an update to frequenz-api-common.
Changes:
- Update the “Stable
v1API” section to also mentionv1alpha18. - Adjust wording about whether users need to update dependencies.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ## Stable `v1` and `v1alpha18` APIs | ||
|
|
||
| The `v1` API is stable and has **not** been changed in this release. Users currently on `v1` do not need to make any changes, beyond potentially updating python dependencies as described below. | ||
| The `v1` and `v1alpha18` APIs are stable and have **not** been changed in this release. Users currently on these API versions do not need to make any changes, beyond potentially updating python dependencies. |
There was a problem hiding this comment.
PR title indicates an update to frequenz-api-common v0.8.3, but this edited section frames the release notes around API version stability (v1, v1alpha18, v1alpha19) without mentioning the dependency bump. If the primary change in this release is the frequenz-api-common update, consider explicitly calling it out here (or in the Summary/Dependency Updates section) so the release notes match the PR intent.
llucax
left a comment
There was a problem hiding this comment.
Approving but this will probably fail once in the merge queue and the whole matrix is tested, as the minimum dependencies will be older than the required by the new commit API. Will submit a PR to fix that soon.
Understood. This can wait until your PR gets merged. |
479beed to
4282097
Compare
Signed-off-by: Tiyash Basu <tiyash.basu@frequenz.com>
Signed-off-by: Tiyash Basu <tiyash.basu@frequenz.com>
4282097 to
609445c
Compare
No description provided.